https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40294
--- Comment #28 from David Nind <[email protected]> --- I've retested, but have not signed off: 1. I don't seem to be getting the same results as I got with previous testing. I'm sure things worked as expected - the right type of notices were queued. 2. However, I seem to be getting different results now - see the results for each step below. No longer sure what is expected with the different settings. 3. Tests pass if I just apply the patches, run the database and restart_all. 4. However, after configuring things for the tests and working through the test plan, the tests no longer pass. Retesting ========= Applied patches first and ran updatedatabase and restart_all Step 9: - No message options selected under messaging preferences for either patron category or the individual patron (for Patron account expiry (mandatory)). - Ran: perl misc/cronjobs/membership_expiry.pl -c -v -before 10 -after 10 - For the patron, a MEMBERSHIP_EXPIRY print notice was queued Step 10: Email address for patron (as well as sms and primary phone numbers) - Patron category messaging preferences: - Individual options selected for the patron category (no options set for individual patron): . SMS: email notice queued . Phone: email notice queued . Email: email notice queued - All options selected for the patron category: one email notice queued - So it looks like only the email notice is queued, which doesn't seem correct - Individual patron messaging preferences (no options set for patron category): - Individual options selected for the individual patron: . SMS: sms notice queued (as expected) . Phone: phone notice queued (as expected) . Email: email notice queued (as expected) - All options selected for the individual patron: sms, phone, and email notices queued - So looks like this is working as expected Steps 12 and 13: No selection for both individual patron messaging preferences and patron category messaging preferences: - phone notice queued (result expected as per the test plan) Step 14: No email address for patron (but does have sms and primary phone numbers) - Patron category messaging preferences: - Individual options selected for the patron category (no options set for individual patron): . SMS: phone notice queued . Phone: phone notice queued (as expected) . Email: phone notice queued - All options selected for the patron category: one phone notice queued - Not sure what is expected, but this doesn't seem correct to me - Individual patron messaging preferences (no options set for patron category): - Individual options selected for the individual patron: . SMS: sms notice queued (as expected) . Phone: phone notice queued (as expected) . Email: print notice queued (as expected(?)) - All options selected for the individual patron: sms, phone, and print notices queued (as expected) - Seems to be working as expected Tests ===== After applying all the patches, and updatedatabase, and a restart_all the tests pass for me. However, after working through the test plan and then running again, the tests fail for me. prove t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patrons.t .. 42/52 # Looks like you planned 15 tests but ran 11. # Failed test 'queue_notice' # at t/db_dependent/Koha/Patrons.t line 3486. Can't call method "store" on an undefined value at t/db_dependent/Koha/Patrons.t line 3386. # Failed test 'no warnings' # at /usr/share/perl/5.40/Test/Builder.pm line 193. # There were 1 warning(s) # Previous test 11 'Count of queued notices not increased in test mode' # Violation of unique constraint in Letter at /kohadevbox/koha/t/lib/TestBuilder.pm line 365. # at /kohadevbox/koha/t/lib/TestBuilder.pm line 365. # t::lib::TestBuilder::_buildColumnValues(t::lib::TestBuilder=HASH(0x5610610bf4e8), HASH(0x56106dbca220)) called at /kohadevbox/koha/t/lib/TestBuilder.pm line 121 # t::lib::TestBuilder::build(t::lib::TestBuilder=HASH(0x5610610bf4e8), HASH(0x56106dc43b90)) called at /kohadevbox/koha/t/lib/TestBuilder.pm line 87 # t::lib::TestBuilder::build_object(t::lib::TestBuilder=HASH(0x5610610bf4e8), HASH(0x56106dbf2e00)) called at t/db_dependent/Koha/Patrons.t line 3386 # main::__ANON__() called at /usr/share/perl/5.40/Test/Builder.pm line 374 # eval {...} called at /usr/share/perl/5.40/Test/Builder.pm line 374 # Test::Builder::subtest(Test::Builder=HASH(0x5610612824e0), "queue_notice", CODE(0x56106d9b7d80)) called at /usr/share/perl/5.40/Test/More.pm line 831 # Test::More::subtest("queue_notice", CODE(0x56106d9b7d80)) called at t/db_dependent/Koha/Patrons.t line 3486 # # Looks like your test exited with 11 just after 44. t/db_dependent/Koha/Patrons.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 10/52 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patrons.t (Wstat: 2816 (exited 11) Tests: 44 Failed: 2) Failed tests: 43-44 Non-zero exit status: 11 Parse errors: Bad plan. You planned 52 tests but ran 44. Files=1, Tests=44, 61 wallclock secs ( 0.09 usr 0.02 sys + 39.49 cusr 15.32 csys = 54.92 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
