https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35145

Laura Escamilla <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #95 from Laura Escamilla <[email protected]> ---
I ran the QA tools and noticed one issue with
`koha-tmpl/intranet-tmpl/prog/en/includes/member-attribute-types.inc`.

The template checks fail with:

`missing_filter at line 1 ([%- KOHA -%])`

It looks like the first line is currently:

```tt
[%- KOHA -%]
```

I think this should either be:

```tt
[%- USE Koha -%]
```

if the Koha TT plugin is intended to be loaded, or the line can be removed
entirely if it's not needed. As written, the template linter interprets `KOHA`
as output and expects an output filter.

Aside from that, I also hit the expected tidiness failures on several Perl
files (`tidy.pl`) and a missing final newline in `members/memberentry.pl`.

I'm marking this as Failed for visibility so these issues don't get overlooked,
but I'm happy to switch this to Passed QA once they're cleaned up. Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to