https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41932
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #39 from David Nind <[email protected]> --- The patches still apply, but the tests didn't pass for me on current main. Questions: 1. I'm not sure how to do step 9 of the consolidated test plan I wrote below. Is there anything else that needs configuring in Koha? 2. Description of this issue - I've started to try and explain this change in words I can understand, but since I'm not familiar with this area, it needs some more work and there are some gaps! 3. For the system preference description, suggested changes (happy to add a follow-up patch with suggestion): - first sentence: callnumbers to call numbers - i.e. to: that is - Examples - 2 first level bullet points with the examples: - ^A\s:2,4;1,3 ... Examples (with zero-padding number used for the sort): .. XXXX (zero-padded number) .. XXXX (zero-padded number) - 1 4 ... Examples: .. XXXX (zero-padded number) .. XXXX (zero-padded number) 4. For the input field for the system preference, should there be more space to add formats? Description =========== The new ClassSortGenericFormats system preference allows libraries to define custom call number sorting rules for the generic classification filing rule. Currently: What is the problem with an example With this change: What this allows libraries to do Examples: [provide a before and after example, maybe we should have some examples for "common" types of things libraries try to do] Testing notes (using KTD) ========================= 1. Reproduce the issue: didn't attempt to 2. Apply the patches 3. Update the database: updatedatabase 4. Restart everything: restart_all 5. Tests should pass: prove t/ClassSortRoutine_Generic.t 6. Add a few call number formats in the new ClassSortGenericFormats system preference: ^A:1,3;1,2;;^B:1,2 In words: call number starts with A, 1 or more digits (pad to 3), then 1 or more digits (pad to 2). Or call number starts with B, one or more digits (pad to 2). 7. Enable generic call number sorting rules in the Classification configuration (if no generic rule already): - Administration > Cataloging > Classification configuration - Classification filing rules - existing rule in place for KTD: . general, Generic call number filing rules, Generic 8. Edit some items and add call numbers (o - Full call number): 1 A 1, 10 A 2, B2, B11. ==>9. Check if cn_sort now matches: 001_A_01, 100_A_02, B02, B11 Not sure how to do this or if there is something else required to make this work. SQL query I tried: select * from items where itemcallnumber IS NOT NULL; - Not sure what I should see, this is what is in the cn_sort column: . 1 A 1: 1_000000000000000_A_1 . 10 A 2: 10_000000000000000_A_2 . B2: B_2_000000000000000 . B11: B_11_000000000000000 - If I add the call numbers to a single record with four items (Perl template toolkit (255)), and sort on the call number column in the holdings table: . 1 A 1 . 10 A 2 . B11 . B2 10. Review the description for the new ClassSortGenericFormats and check that it makes sense - feedback welcome to improve this. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
