https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41898
--- Comment #38 from Paul Derscheid <[email protected]> --- Created attachment 202472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202472&action=edit Bug 41898: (QA follow-up) Skip clash detection when collecting a booking Transitioning a booking to 'issued' no longer skipped clash detection, and Item::check_booking treats any live checkout on the item as a clash. Switching an on-site checkout of a booked item to a regular checkout (SwitchOnSiteCheckouts) therefore crashed AddIssue with an unhandled Koha::Exceptions::Booking::Clash; collection could fail the same way whenever the biblio's bookable item pool had shrunk since the booking was placed. - short-circuit no-op stores before validation; circulation issues redundant status writes that must not re-trigger the checks - rename _is_final_status_transition to _skip_clash_detection and also skip when transitioning to 'issued' from an active status, as long as the booked period and item are unchanged - keep validating period/item changes and reactivations of terminal bookings - cover the on-site switch in Circulation.t and the store() semantics in Booking.t Test plan: 1. Enable OnSiteCheckouts and SwitchOnSiteCheckouts 2. Place a booking starting today for a patron 3. Check the booked item out to that patron from Circulation > Check out with 'On-site checkout' ticked. Do NOT use the bookings page's 'Transform to checkout' button: it submits a fixed field set that does not carry the on-site flag (Bug 36789), so the checkout would silently be a regular one and step 4 could not reproduce the switch 4. The booking shows 'Issued'. Scan the same barcode for the same patron again to switch the on-site checkout to a regular one; this crashed with Koha::Exceptions::Booking::Clash before the patch and now succeeds with the booking still 'Issued' 5. prove t/db_dependent/Koha/Booking.t t/db_dependent/Circulation.t Signed-off-by: Paul Derscheid <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
