https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42997
--- Comment #19 from Paul Derscheid <[email protected]> --- Created attachment 202494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202494&action=edit Bug 42997: (QA follow-up) Don't let a booking's own checkout block it in Biblio::check_booking Koha::Biblio->check_booking counts current checkouts on bookable items against the pool of available items. Like Item::check_booking before this patchset, it made no exception for the checkout that belongs to the very booking being validated, so updating an issued booking's period could clash against its own loan whenever the new period no longer overlaps the stored one (the item_id exemption for booked items only catches bookings that overlap the window under test). This is masked in the end_date syncs earlier in this patchset because the synced window always contains the stored start_date; it surfaces as soon as a sync moves the whole period, and would equally bite the extension pathway on bug 42790. - skip checkouts whose booking_id matches the booking being validated when counting occupied bookable items, mirroring the Item::check_booking exemption - cover the blocking and non-blocking checkout cases in Biblio.t Test plan: 1. prove t/db_dependent/Koha/Biblio.t Signed-off-by: Paul Derscheid <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
