https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43191
Bug ID: 43191
Summary: Clean up printer profiles saved with a blank printer
name or paper bin
Initiative type: ---
Sponsorship ---
status:
Product: Koha
Version: Main
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Label/patron card printing
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
Target Milestone: ---
Bug 21052 allowed a printer profile to be saved with a blank printer name
or paper bin: the editors did not validate the two fields, so a blank was
stored as an empty string. Any site that hit that bug has at least one such
row in printers_profile.
The patch on bug 21052 stops new blank rows being created and makes an
existing blank row repairable in place (a blank stored value renders as an
editable input rather than read-only), so no site is stuck. It deliberately
ships no data fix, because repairing existing rows is a separate concern from
the code defect and wants its own test plan.
What is left to decide here:
- Whether to repair or remove the affected rows. A blank profile cannot be
meaningfully applied to a template, so removal is plausible, but a row may
be referenced by printers_profile.template_id associations a site still
wants.
- Whether an atomicupdate should act at all, or simply report the affected
rows so the library can choose.
To find affected rows:
SELECT profile_id, printer_name, paper_bin, creator
FROM printers_profile
WHERE TRIM(printer_name) = '' OR TRIM(paper_bin) = '';
Depends on bug 21052 -- the validation fix should land first so that no new
blank rows appear while this is being decided.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
