https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391
Pedro Amorim (ammopt) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #233 from Pedro Amorim (ammopt) <[email protected]> --- Hey guys, I understand this is an old bug and the urgency to get this pushed, but I have to FQA for now: Part 1: opac-detail.tt / opac-basket.tt (default config, useRecalls = 'off') 1) Confirm UseRecalls is at its default (off) 2) Check out item 39999000003154 to patron 'Henry Acevedo' 3) Log into the OPAC as a different patron (e.g. koha user) 4) As koha user, go to the biblio detail page for the record we just checked out: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=76 5) Look at the item's status row: next to "Checked out", a "Recall" button is visible, even though UseRecalls is off. 6) Click it, lands on opac-recall.pl, shows a "Recalls have not been enabled. Please contact your library.", which confirms it's a dead-end button that never should have rendered. 7) Same thing reproduces in the basket: as koha user, add that biblio to your cart (Add to cart on the results/detail page), then click the cart icon on the top left. The same button erroneous will show. Part 2: opac-course-details.tt — staff-only mode still leaks the OPAC link 1) Continuing from the previous instructions: Set UseRecalls to "can be placed through the staff interface only". 2) Add the same checked-out item (39999000003154) to a course reserves list — http://localhost:8081/cgi-bin/koha/course_reserves/course-details.pl?course_id=1 3) Click "Add reserves" 4) As koha user on the OPAC, view that course's page: http://localhost:8080/cgi-bin/koha/opac-course-details.pl?course_id=1 5) The "Recall" button shows here too, even though UseRecalls=staff should mean OPAC patrons can't place recalls at all. Non-blocking, but ideally also to be addressed: A) The recalls_per_record logic is copy-pasted near verbatim between opac/opac-recall.pl (48-65) and recalls/request.pl (61-78). This is a big maintenance risk if the rule ever changes. Should live in one shared method. B) The pref is mocked to '1' (the old value) in Holds.t -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
