https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29168
--- Comment #24 from Tomás Cohen Arazi (tcohen) <[email protected]> --- Created attachment 202850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202850&action=edit Bug 29168: (regression test) explicit article request denial overridden by wildcard guess_article_requestable_itemtypes does not track explicit 'no' rules for specific itemtypes. When a wildcard rule (NULL itemtype) allows article requests and a specific itemtype rule denies them, the denied itemtype does not appear in the returned hash. The search results page then falls through to the wildcard and incorrectly shows the 'Request article' link. Additionally, opac-search.pl uses || (or) for the lookup, which treats an explicit 0 as falsy and falls through to the wildcard. It should use // (defined-or) to respect explicit denials. Test plan: 1. Apply patch 2. ktd --shell k$ prove t/db_dependent/Koha/CirculationRules/guess_article_requestable_itemtypes.t => FAIL: Tests 3 and 4 in the new subtest fail 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
