https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36369
--- Comment #33 from Tomás Cohen Arazi (tcohen) <[email protected]> --- Created attachment 202876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202876&action=edit Bug 36369: (follow-up) Route get_from_barcode through KohaApiClient preservation-api-client.js waiting_list_items.get_from_barcode() was the only client method left calling this.httpClient directly instead of the KohaApiClient wrapper. Doing so bypasses _resolveEmbed() (and _withCsrf(), harmless here as this is a GET), which is why the previous patch could not convert this call to the declarative embed syntax: `embed: [...]` would have been passed straight through to HttpClient and silently dropped, and the waiting list items would have come back without their biblio. This patch switches the call to this.get() and converts it to the declarative embed syntax, so no client method reaches around the base class anymore. Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ qa -c 1 => SUCCESS: QA passes 3. Go to Preservation > Waiting list 4. Add an item to the waiting list by scanning/typing a barcode => SUCCESS: The item is found and its title/author (from the embedded biblio) is displayed in the list 5. Confirm in the devtools network tab that the request to /api/v1/preservation/waiting-list/items still carries the x-koha-embed: biblio header 6. Enter a barcode that does not exist => SUCCESS: Handled as before, no item is added 7. Sign off :-D Assisted-by: Opus 5 (Anthropic) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
