https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41932
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #57 from David Nind <[email protected]> --- Thanks for the improvements to the system preference description and the updated test plan. The tests fail for me[1]. Everything else seems to be working as per the test plan, although there doesn't seem to be leading 0s in the cn_sort column as per step 9 of the test plan they do sort correctly in the staff interface. Testing notes (using KTD): 1. Before the patches, I used The definitive guide to Catalyst (biblionumber = 146) with four items. Added A 11, A9, A 25 as call numbers and left one blank. +----------------+----------------------+ | itemcallnumber | cn_sort | +----------------+----------------------+ | A 11 | A_11_000000000000000 | | A 9 | A_9_000000000000000 | | A 25 | A_25_000000000000000 | | NULL | _ | +----------------+----------------------+ When sorting the holdings table on the call number column - sort order ascending is: A 11, A 25, A 9 (instead of A 9, A 11, A 25) 2. After the patch, I used Intermediate Perl (biblionumber = 126) and added call numbers. +----------------+-------------------------+ | itemcallnumber | cn_sort | +----------------+-------------------------+ | A 2 | A_2_000000000000000 | | B2 | B_2_000000000000000 | | A 1 12-1 | A_1_000000000000000_121 | | B22c | B_22C | | B123 45 | B_123_450000000000000 | | C4 | C_4_000000000000000 | +----------------+-------------------------+ When sorting the holdings table on the call number column - sort order ascending is: A 1 12-1 A 2 B123 45 B2 B22c C4 [1] Test failure ================ Tests fail: prove t/ClassSortRoutine_Generic.t t/ClassSortRoutine_Generic.t .. 1/3 # Failed test 'no warnings' # at /usr/share/perl/5.40/Test/Builder.pm line 193. # There were 1 warning(s) # Previous test 0 '' # Attempt to call undefined import method with arguments ("get_class_sort_key") via package "C4::ClassSortRoutine::Generic" (Perhaps you forgot to load the package?) at t/ClassSortRoutine_Generic.t line 8. # at t/ClassSortRoutine_Generic.t line 8. # main::BEGIN() called at t/ClassSortRoutine_Generic.t line 8 # eval {...} called at t/ClassSortRoutine_Generic.t line 8 # # Looks like you failed 1 test of 3. t/ClassSortRoutine_Generic.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report ------------------- t/ClassSortRoutine_Generic.t (Wstat: 256 (exited 1) Tests: 3 Failed: 1) Failed test: 3 Non-zero exit status: 1 Files=1, Tests=3, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.38 cusr 0.07 csys = 0.48 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
