https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36682
--- Comment #15 from Victor Grousset/tuxayo <[email protected]> --- Thanks a lot for having found differentiators between Modern Yarn and pnpm and going for it! :D It works, here is a second signoff. ----- More testing: If running pnpm install from /kohadevbox/koha it will (as with our current Yarn) redownload and duplicate the dependencies in /kohadevbox/koha. If I do some sabotage with `mv node_modules/prettier node_modules/prettier-fail/` `pnpm exec prettier --version` will fail, so it confirms this is the version used. These dependencies will get old and cause weird bugs as the dependencies shipped with the ktd image will diverge. I don't think there is a reason to worry more about that than with the current setup. Then, to recover from such a situation, I deleted node_modules and .pnpm-store (now full, it was only containing empty dirs after the test plan). And then `pnpm exec prettier --version` worked. It still manages to find the dependencies in the parent directory. It's because of the $PATH containing /kohadevbox/koha/node_modules/.bin/:/kohadevbox/node_modules/.bin/ Weird finding: `pnpm store path` ↓↓ /kohadevbox/koha/.pnpm-store/v10 (which doesn't exist, or was full of empty dirs before my experiment) I don't if that can be and issue. I don't know if there something else to check for when someone inevitably accidently run `pnpm install` from /kohadevbox/koha ? ---- Currently, the clean way to install the dependencies from the lock file is: sudo yarn install --modules-folder /kohadevbox/node_modules (add package name to install it instead) And now it's cd /kohadevbox sudo pnpm install Is that correct? At some point running yarn as root wasn't needed anymore so I the migration to pnpm would change that. But no, yarn as root is how it works currently so with pnpm it's not changing. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
