https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42656
--- Comment #10 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 202926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202926&action=edit Bug 42656: (QA follow-up) Fix dead status code in file_transport_test.inc Two issues in the operation_description BLOCK's status text, both flagged in review: 1) The IF/SET that computed the " passed."/" failed." status text sat between the SWITCH statement and its first CASE. Template Toolkit only executes CASE-labelled content inside a SWITCH block, so this was dead code - status was never actually set, and every operation row silently rendered with no passed/failed text at all. It also checked operation.error, a field that doesn't exist on the operation hash (the error message lives under operation.detail.error, and whether the operation failed is operation.status eq 'error'); even if the code path were reachable it would always have taken the "passed" branch. 2) Relying on a leading space baked into the " passed."/" failed." string literals to separate them from the preceding </span> is fragile. Made the space explicit in the markup instead, and dropped the leading space from the string values. Moves the status computation above the SWITCH (using operation.status), and adds an explicit space before [% status | html %] on every CASE line. Also adds t/db_dependent/Koha/BackgroundJob/TestTransport.t, which was entirely missing: it exercises process() end-to-end (enqueue, then process, then reload both the job and the transport) and confirms the persisted trace records every operation in sequence - successes before the failure that ended the run - rather than collapsing to just the final error. Test plan: 1. prove t/db_dependent/Koha/BackgroundJob/TestTransport.t => All tests successful, confirming process() persists the full operation sequence (order preserved, at least one success and one error present) on both the job and the transport's own status column. 2. Manually rendered the fixed operation_description BLOCK with Template Toolkit against mock operations (mixed success/error) and confirmed every row now shows "Connection passed.", "Change directory (/incoming) passed.", ..., "Change directory (/outgoing) failed.- error:No such directory" - status text present with correct spacing, where before the fix no status text rendered at all. 3. prove -r t/db_dependent/Koha/File/ t/db_dependent/Koha/Edifact/Transport.t t/db_dependent/api/v1/file_transports.t => All tests successful (47 tests total), no regressions. 4. koha-qa.pl -v 2 --more-tests => [PASS], no critic/pod warnings. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
