https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40668
--- Comment #6 from Lisette Scheer <[email protected]> --- Created attachment 202965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202965&action=edit Bug 40668: Don't depend on checkboxes existing in drawCallback The checkboxes this callback listens to events on are conditionally rendered, depending on whether the user has permission to edit each item. When moving from a page with no checkboxes displayed to one with checkboxes displayed, the checkbox elements may not exist at the time of this callback, so the listener is not attached and the checkboxes are inoperable. This patch fixes this by using a delegated event handler on the row, which doesn't depend on the checkbox existing at the time. Test plan: 1. Enable the system preference EnableItemGroups. 2. Set up a non-super-librarian patron, with permission to: - view the catalogue (catalogue) - create update and delete item groups (manage_item_groups) 3. Place this patron's library in a group by itself, with "limit item editing" enabled. The patron should only be able to edit items from their own library. 4. Pick an item in the catalogue, and add at least 40 items to it from a library the patron cannot edit items from. Add at least one item from the patron's library that they can edit. The 40 items are to ensure there is a complete (20 item) page that the patron cannot edit anything on. 5. Create an (empty) item group on this catalogue entry. 6. Log in as the unprivileged patron and navigate to the holdings view for the relevant catalogue entry. 7. Navigate through the holdings table pages until there is a page with no checkboxes. 8. Navigate to a table page with a checkbox. Select one of the checkboxes, and verify no actions appear at the top of table, even though you should have permission to add this item to a group. 9. Apply this patch, and hard refresh to load the new JavaScript. 10. Repeat steps 6-8, verifying the checkbox now appears correctly. 11. Verify you can add the item to an item group using the now-appearing action. Sponsored-by: Open Fifth Signed-off-by: David Nind <[email protected]> Signed-off-by: Lisette Scheer <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
