https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39589
--- Comment #24 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 202972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202972&action=edit Bug 39589: (QA follow-up) Don't zero hits when a page has no visible results Zeroing $hits alongside the no_page_results flag also zeroed $total (since $total accumulates $hits, and the final template 'total' param is set from $hits/$total). Because the top "No results found!" banner and the entire search-results section are both gated on 'total' being true, this meant the new no_page_results branch could never actually render: whenever it was true, 'total' was false, so the classic "No results found!" page won instead - recreating the exact bug this patch is meant to fix. Verified against the bug's own test plan (OPACnumSearchResults=5, OpacHiddenItemsHidesRecord, OpacHiddenItems: withdrawn:[1], 6 bibs with the first 5 withdrawn/hidden): before this change, page 1 still showed "No results found!" with no pagination; after this change, it shows "Your search returned 6 results" / "Search results on this page are not available", with a working pagination link to the page containing the visible record. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
