https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450
David Nind <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Keywords| |release-notes-needed Status|Needs Signoff |Failed QA --- Comment #44 from David Nind <[email protected]> --- This seems to work as expected for me. However, I've set the status to Failed QA because there is some extra text before the "Override and renew" button when AllowRenewalOnHoldOverride is set to "Allow": "PLOP:" (see step 6 of my testing notes). Testing notes (using KTD): 1. Make sure these system preferences as set: - AllowRenewalOnHoldOverride = Don't allow - AllowRenewalIfOtherItemsAvailable = Don't allow 2. Get message when attempting to renew before the patch (issue as described for the bug): Cannot renew: Programming Perl / ( 39999000011418 ): This item is on hold for another patron. Renewal due date: _____________ X Override and renew Continue without renewing 3. Apply the patch. 4. With the patch, the message is (as expected): Cannot renew: Programming Perl / ( 39999000011418 ): This item is on hold for another patron. Continue without renewing 5. Set the system preferences to: - AllowRenewalOnHoldOverride = Allow (changed) - AllowRenewalIfOtherItemsAvailable = Don't allow (not changed) 6. The message is the same as in step 2, however there is some extra text before the "Override and renew" button: PLOP 7. Set the system preferences to: - AllowRenewalOnHoldOverride = Allow (unchanged) - AllowRenewalIfOtherItemsAvailable = Allow (changed) 8. Same message as before with the extra text ("PLOP"). Additional testing (after patch applied) - AllowRenewalIfOtherItemsAvailable: 1. I'm not sure if I understand AllowRenewalIfOtherItemsAvailable correctly, but I tested with a record that has multiple items available: - Perl template toolkit (255), item 39999000011111 2. With the system preferences set to: - AllowRenewalOnHoldOverride = Don't allow - AllowRenewalIfOtherItemsAvailable = Don't allow Get the message (seems as expected): Cannot renew: Perl template toolkit / ( 39999000011111 ): This item is on hold for another patron. Continue without renewing 3. With the system preferences set to: - AllowRenewalOnHoldOverride = Allow (changed) - AllowRenewalIfOtherItemsAvailable = Don't allow (unchanged) Get the message (seems as expected): Cannot renew: Perl template toolkit / ( 39999000011111 ): This item is on hold for another patron. Renewal due date: _____________ X Override and renew Continue without renewing 4. With the system preferences set to: - AllowRenewalOnHoldOverride = Allow (unchanged) - AllowRenewalIfOtherItemsAvailable = Allow (changed) Get the message (as expected, other items are available so renewed without any override required messages): Item renewed: Perl template toolkit / ( 39999000011111 ) renewed for Henry Acevedo ( 23529000035676 ) now due on 08/14/2026 -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
