https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21264
--- Comment #10 from Emmi Takkinen <[email protected]> --- (In reply to Katrin Fischer from comment #9) > (In reply to Emmi Takkinen from comment #8) > > (In reply to Katrin Fischer from comment #7) > > > (In reply to Emmi Takkinen from comment #6) > > > > (In reply to Katrin Fischer from comment #5) > > > > > (In reply to Emmi Takkinen from comment #4) > > > > > > We are having problems with NULL values in > > > > > > subscription.previousitemtype > > > > > > column. When one receives multiple copies of a serial those NULL > > > > > > values > > > > > > attempt to create items with itype as NULL. > > > > > > > > > > > > Could we just make "item type for older issues" field mandatory? > > > > > > > > > > I think our libraries would not all like that - why not correct the > > > > > behavior > > > > > and make the item type field mandatory on the item form? So if > > > > > nothing is > > > > > selected, the item can't be saved. That should already be the case > > > > > but maybe > > > > > it's not if the items can be created with null. I believe we have > > > > > also seen > > > > > that faulty behavior. > > > > > > > > All our item forms have mandatory itemtype field but this doesn't fix > > > > the > > > > problem completely. If syspref "makePreviousSerialAvailable" is enabled > > > > Koha > > > > tries to fill previous serials itype field with value from > > > > subscription.previousitemtype (code on serials-edit.pl lines 247-271) > > > > and if > > > > that value is NULL then we run into problems. > > > > > > > > Of course this wouldn't be an issue for us if we had same itemtype in > > > > both > > > > items.itype and biblioitems.itemtype columns and we could rely on > > > > Item->store to fill itype correctly. > > > > > > I think the other solution would be to not activate the mechanism if the > > > field is not set and keep the existing itemtype. That would only require a > > > change to the logic and no data changes or similar. > > > > Hmm, that's probably the best solution and suitable for everyone. Maybe > > there could be a note next to "item type for older issues" field where we > > tell that if the field is not filled, existing itemtype is used. > > Sounds good to me - could you file a separate bug? New bug 43239 created. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
