https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19814

--- Comment #93 from Martin Renvoize (ashimema) 
<[email protected]> ---
Created attachment 203248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203248&action=edit
Bug 19814: (follow-up) Enforce hold and transfer sysprefs server-side

The client-side JS disables the "Automatically capture holds" and
"Automatically create transfers" checkboxes when HoldsAutoFill or
AutomaticItemReturn is enabled, but a bypassed or customised client
could still POST without those params. The server now treats those
sysprefs as authoritative: when either is on, process_batch_checkin_item
behaves as though the matching checkbox was ticked, regardless of form
state.

Also replaces the two #TODO Hold not found silent skips with
Koha::Logger warnings so a hold that disappears between checkin and
confirm is observable in the logs instead of being dropped on the floor.

Test plan:
1. Enable HoldsAutoFill, leave AutomaticItemReturn off.
2. In batch mode, scan an item with a waiting hold without ticking
   "Automatically capture holds" -> the hold is still auto-affected.
3. Enable AutomaticItemReturn, leave HoldsAutoFill off.
4. In batch mode, scan an item belonging to another branch without
   ticking "Automatically create transfers" -> the transfer is still
   auto-initiated.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to