https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42314
--- Comment #18 from Tomás Cohen Arazi (tcohen) <[email protected]> --- Created attachment 203311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203311&action=edit Bug 42314: (QA follow-up) Drop lazy require in Koha::Library->calendar The accessor loaded Koha::Calendar via runtime require on every call, presumably as a guard against a circular dependency. No such cycle exists: Koha::Calendar and its Koha::Calendar::* children do not use Koha::Library. Replace the runtime require with a top-level use so the module loads once at compile time, matching the other Koha::* imports in this file. Also expand the POD a little to mention what the returned Koha::Calendar is scoped to and what it is typically used for. Test plan: 1. prove t/db_dependent/Koha/Library.t 2. Check POD coverage: perl -MPod::Coverage=Koha::Library -e 1 Signed-off-by: Tomás Cohen Arazi <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
