https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42540

--- Comment #13 from David Cook <[email protected]> ---
Comment on attachment 202894
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202894
Bug 42540: Trap and throw elastic too_many_clauses errors instead of just dying

Review of attachment 202894:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=42540&attachment=202894)
-----------------------------------------------------------------

::: svc/import_bib
@@ +97,5 @@
> +    my $number_of_matches;
> +    try {
> +        $number_of_matches = BatchFindDuplicates( $batch_id, $matcher );
> +    } catch {
> +        if ( blessed $_ and 
> $_->isa('Koha::Exceptions::Elasticsearch::TooManyClauses') ) {

The blessed here is bugging me... 

If you tried to run svc/import_bib in CGI mode it would throw an error like
this:

Can't locate object method "blessed" via package "CGI"

I'm guessing it might work under Plack because some package loaded in
plack.psgi is importing "blessed" into the "main" namespace, but... that's a
recipe for disaster in the long term, so I think it would be necessary to add
'use Scalar::Util qw( blessed );' to the top of the file...

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to