https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137
--- Comment #169 from Thibaud Guillot (thibaud_g) <[email protected]> --- (In reply to David Nind from comment #167) > Happy to sign off as things seem to work as expected - see my testing > notes.[1] > > However, I have Failed QA because of the qa script FAILS and WARNINGS - see > qa script FAIL and WARNINGS.[2] > > [1] Testing notes (using KTD) > ============================= > > 1. Rules set up after patches applied, and so on: > > All All rule for all libraries: > - Current checkouts allowed: 2 > - Current on-site checkouts allowed: 2 > > Kid All rule for all libraries: > - Current checkouts allowed: 5 > - Current on-site checkouts allowed: 5 > > All All rule for Centerville: > - Current checkouts allowed: 5 > - Current on-site checkouts allowed: 5 > > All All rule for Midway: > - Current checkouts allowed: 5 > - Current on-site checkouts allowed: 5 > > New "Global checkout limits" section: > - All All: 1 for both options > - Kid All: 2 for both options > > 2. Testing checkouts (check items back in after each step)/ > > 2.1 . Library is set to Centerville: > . Mary Burton - with the above rules, should only be able to check out > one item in total > . Items to check out: 39999000011418, 39999000000498 > ==> can't checkout the second item (as expected), message is: > > Please confirm checkout > - Too many checked out. 1 checked out, only 1 are allowed. > - Maximum checkouts calculated from the circulation rule for > . Item type: All item types > . Patron category: All patron categories > . Library: All libraries > > 2.2 Library is set to Midway: > . Lisa Charles - with the above rules, should only be able to checkout > two items in total > . Items to check out: 39999000001532, 39999000006155, 39999000005097 > ==> can't check out the third item (as expected), message is: > > Please confirm checkout > - Too many checked out. 2 checked out, only 2 are allowed. > - Maximum checkouts calculated from the circulation rule for > . Item type: All item types > . Patron category: Kid > . Library: All libraries > > 2.3 Remove global rules, then attempt these check outs: > > - Centerville: attempt to check out 6 items to Mary (39999000011418, > 39999000000498, 39999000005134, 39999000005776,39999000011111, > 39999000011135), should only be able to checkout 5, message is: > > Please confirm checkout > - Too many checked out. 5 checked out, only 5 are allowed. > - Maximum checkouts calculated from the circulation rule for > . Item type: All item types > . Patron category: All patron categories > . Library: Centerville > > - Then attempt to check out 6 items to Mary with Midway as the library > (39999000001532, 39999000006155, 39999000005097, 39999000007077, > 39999000004595, 39999000004618), should only be able to checkout 5, message > on 6th item is: > > Please confirm checkout > - Too many checked out. 5 checked out, only 5 are allowed. > - Maximum checkouts calculated from the circulation rule for > . Item type: All item types > . Patron category: All patron categories > . Library: Midway > > - Then attempt to checkout 3 items to Mary with Fairview as the library > (39999000008197, 39999000000818, 39999000001518), not able to check out any > as the All All for all libraries is 2 - have exceeded that as have checkout > 10 already (5 at Centerville, 5 at Midway), message is: > > Please confirm checkout > - Too many checked out. 10 checked out, only 2 are allowed. > - Maximum checkouts calculated from the circulation rule for > . Item type: All item types > . Patron category: All patron categories > . Library: All libraries > > [2] qa script fails and warnings > ================================ > > [FAIL] Koha/CirculationRules.pm > FAIL pod_coverage > sub _type has no pod coverage. > ... > [FAIL] admin/smart-rules.pl > FAIL tidiness > File is not tidy, please run `perl misc/devel/tidy.pl > admin/smart-rules.pl` > ... > [FAIL] installer/data/mysql/kohastructure.sql > FAIL tinyint_has_boolean_flag > The new column circulation_rules.has_priority is using > TINYINT(1) as type > but is not defined as boolean in the schema file > (Koha/Schema/Result/CirculationRule.pm), see the SQL12 coding guideline > [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt > WARN spelling > librairies ==> libraries > librairies ==> libraries > FAIL tidiness > File is not tidy, please run `perl misc/devel/tidy.pl > koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt` Hello David, Thank you for this very detailed review. I push another commit to fix this, tidiness, spelling and boolean_flag is related to this bug, for pod_coverage I modify the file but the warn already exists before I think so I also fixed this to make this bug move forward :) Have a nice day -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
