https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24898
--- Comment #4 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 203472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203472&action=edit Bug 24898: (follow-up) Use dedicated 'Checkout' cancellation reason Bug 24298 comment 27/28 already discussed this exact situation back in 2020: Nick Clemens noted that AddIssue closes existing transfers without recording why, and suggested 'Checkout' as a distinct reason; Martin agreed the cancellation reason shouldn't be conflated with what originally triggered the transfer, and split the "we're destroying the original destination" problem off into this bug. Reusing the existing 'WrongTransfer' value (added for AddReturn's "item scanned in at the wrong branch" case) would conflate two different real-world events under one value: a misdelivery caught at check-in versus a transfer overtaken by a checkout elsewhere. Use the new 'Checkout' value instead, so reporting on cancelled transfers can tell the two apart. Test plan: 1. prove t/db_dependent/Circulation.t t/db_dependent/Circulation/ \ t/db_dependent/Koha/Item.t t/db_dependent/Koha/Item/Transfer.t \ t/db_dependent/Reserves.t => All pass -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
