https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41625
--- Comment #1 from Tomás Cohen Arazi (tcohen) <[email protected]> --- Created attachment 203488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203488&action=edit Bug 41625: Use Koha::CSV for label CSV exports This patch replaces direct Text::CSV_XS usage with Koha::CSV in labels/label-create-csv.pl using the low-level API (combine/string). Benefits: - CSVDelimiter system preference used consistently - formula => empty enforced (prevents formula injection) - binary => 1 always set (UTF-8 safe) - Removes direct Text::CSV_XS dependency from the script - Replaces warn with Koha::Logger The label CSV export has fully dynamic columns determined by the layout format_string at runtime, making the columns() subclass pattern unsuitable. The low-level API is the right fit here. Test plan: 1. Apply patches (depends on bug 41620) 2. Create a label batch with items 3. Go to Tools > Label creator > select batch > Export > CSV => SUCCESS: CSV generated with correct fields 4. Verify delimiter matches CSVDelimiter preference 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
