https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41632
--- Comment #1 from Tomás Cohen Arazi (tcohen) <[email protected]> --- Created attachment 203494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203494&action=edit Bug 41632: Use Koha::CSV for overdue exports This patch introduces Koha::CSV::Overdues, a subclass of Koha::CSV with fixed column definitions for the overdue report, and updates both circ/overdue.pl and misc/cronjobs/overdue_notices.pl. circ/overdue.pl: - Replaces the build_csv() function with Koha::CSV::Overdues - Uses export() with arrayref of overdue hashrefs - Privacy filtering applied before export misc/cronjobs/overdue_notices.pl: - Replaces Text::CSV_XS with Koha::CSV low-level API - Same combine/string pattern (cron script has different flow) Benefits: - formula => empty enforced (prevents formula injection) - CSVDelimiter system preference used consistently - Overdue columns defined once in Koha::CSV::Overdues - Removes build_csv function and Text::CSV_XS dependencies Test plan: 1. Apply patches (depends on bug 41620) 2. Go to Circulation > Overdues, export as CSV => SUCCESS: CSV generated with all columns 3. Test with restricted patron visibility => SUCCESS: Private fields blanked appropriately 4. Run overdue_notices.pl with --csv: k$ perl misc/cronjobs/overdue_notices.pl -n --csv /tmp/overdues.csv => SUCCESS: CSV file generated 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
