https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42386

--- Comment #65 from Martin Renvoize (ashimema) 
<[email protected]> ---
Created attachment 203524
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203524&action=edit
Bug 42386: (follow-up) Fix stale camelCase status codes in hold templates

opac-reserve.tt was never updated for the snake_case status rename and
wasn't in the original patchset's file list, even though opac-reserve.pl
sets its per-item hash key directly from CanBookBeReserved's status
string. OPAC patrons blocked by age restriction, hold limits, or an
existing hold on the item saw only the generic "This title cannot be
requested" message instead of the specific reason.

reserve/request.tt and opac-user.tt also missed two renames:
alreadypossession -> already_possession, and
branchNotInHoldGroup -> branch_not_in_hold_group.

Test plan:
1. Apply patch
2. Place a hold that triggers each affected condition (age restriction,
   too many holds, already in possession, hold-group restriction) from
   both the OPAC search-results/place-hold screen and the staff
   reserve/request.pl page, and confirm the specific message is shown.
3. Sign off :-D

Signed-off-by: Martin Renvoize <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to