https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43291
--- Comment #1 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 203594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203594&action=edit Bug 43291: Use the active currency's isocode for SIP2 responses instead of hardcoded USD C4::SIP::ILS::Transaction's sip_currency field (used for FID_CURRENCY in patron status and fee-related SIP2 responses) was hardcoded to 'USD' with a 'FIXME: why hardcoded?' comment, regardless of the library's actual currency. Use Koha::Acquisition::Currencies->get_active's isocode when one is configured, falling back to 'USD' (the previous behaviour) when no active currency exists. Every C4::SIP::ILS::Transaction subclass calls SUPER::new() first and none of them override sip_currency in their own %fields, so this applies uniformly across checkout, checkin, renew, hold, and fee payment SIP responses. Test plan: 1) prove t/db_dependent/SIP/Transaction.t 2) With no active currency configured, confirm a SIP2 patron status response still reports USD (AY field / currency) 3) Mark a currency (e.g. GBP) as active in Administration > Currencies 4) Repeat step 2 and confirm the response now reports GBP -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
