https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43344
--- Comment #2 from Olivia Reynolds <[email protected]> --- Created attachment 203836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203836&action=edit Bug 43344: Use the current source alias in filter_by_active Bug 36018 qualified the quantity column with the default "me" alias to avoid ambiguity when joined tables also have a quantity column. DBIx::Class does not always use "me" for related resultsets. The many-to-many item_orders relationship uses "ordernumber", so evaluating item.orders.filter_by_active from the OPAC refers to a non-existent me.quantity column. Use current_source_alias to qualify quantity with the alias of the actual resultset. Add regression coverage for filtering active orders through the item relationship. Test plan: Before applying the patch: 1. Set OPACAcquisitionDetails to Show. 2. Set AcqCreateItem to create an item when placing an order. 3. Create a basket and add an order for a bibliographic record, including an item. 4. Close the basket so the order is active and outstanding. 5. Open the bibliographic record in the OPAC. 6. Confirm the item is not shown as On order and the log contains an Unknown column 'me.quantity' error. Apply the patch. After applying the patch: 1. Open the same bibliographic record in the OPAC again. 2. Confirm the item is shown as On order and the SQL error is gone. Co-Authored-By: Loontik <[email protected]> Signed-off-by: Olivia Reynolds <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
