https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26867
--- Comment #2 from Andrii Nugged <[email protected]> --- Created attachment 203938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203938&action=edit Bug 26867: Sort Holds to pull by cn_sort Holds to pull renders one row per bibliographic record and can list several available call numbers in that row. DataTables currently compares the displayed call number text, so classification numbers such as JC43 and JC330 are ordered as JC330, JC43. Order the available call numbers by their normalized classification keys and expose the first key through the table cell's data-order attribute. If an older item has no cn_sort value, retain its displayed call number as the fallback sort key. Add a self-contained Cypress regression for ascending and descending row sorting, aggregated call numbers, and the missing-cn_sort fallback. Test plan: Before applying the patch: 1. Create three bibliographic records with one item each. 2. Give the items the call numbers JC43 .G6 1890, JC330 .F74 2000, and JC480 .R63 2006. 3. Use LOC as the classification source for each item. 4. Place a hold on each bibliographic record. 5. Go to Circulation > Holds to pull. 6. Sort the Available call numbers column in ascending order. 7. Confirm that the items appear as JC330, JC43, JC480. Apply the patch. After applying the patch: 1. Return to Circulation > Holds to pull. 2. Sort the Available call numbers column in ascending order. 3. Confirm that the items appear as JC43, JC330, JC480. Automated tests: 1. yarn cypress run --spec \ t/cypress/integration/KohaTable/PendingHoldsCallNumbers_spec.ts 2. prove -I. -It/lib t/db_dependent/Koha/Holds.t Co-Authored-By: Loontik <[email protected]> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
