https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42332
--- Comment #98 from Jonathan Druart <[email protected]> --- (In reply to Owen Leonard from comment #82) Hi Owen, thanks for testing! > > Bug 42332: DT visibility - tools/upload > > I'm not sure how to test this one. The column hiding seems to be related to > plugins somehow but I'm not sure. Did you see comment 32? ``` * tools/upload Columns "Public" and "Temporary" are hidden if we upload files from the cataloguing plugin "upload" ``` > > Bug 42332: DT visibility - holds-table > > This works if EnableItemGroupHolds is enabled, but I get an error if > EnableItemGroupHolds is disabled. "Uncaught TypeError: can't access property > "sClass", a is undefined" I've noticed another error, squashed this into patch "(bug 41954 follow-up) Fix hold_group_id" admin/columns_settings.yml + - + columnname: hold_group_id - columnname: author koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt @ koha-tmpl/intranet-tmpl/prog/en/modules/members/holdshistory.tt:130 @ - [% IF Koha.Preference('DisplayAddHoldGroups') %] - <th data-colname="hold_group_id">Hold group ID</th> - [% END %] + <th data-colname="hold_group_id">Hold group ID</th> Can you confirm it fixes the error for you? > > Bug 42332: DT visibility - catalogue/detail > > Looks like the only change was with the table of comments under the comments > tab. The "Actions" column is supposed to hidden if the user doesn't have > permission to approve or delete? In my test the column is not hidden. Found 2 bugs there: - <th data-colname="comments">Comment</th> + <th data-colname="comment">Comment</th> var comment_table_settings = [% TablesSettings.GetTableSettings('catalogue', 'detail', 'comments-table', 'json') | $raw %]; - let actions_column = table_settings.columns.find(c => c.columnname == 'actions'); + let actions_column = comment_table_settings.columns.find(c => c.columnname == 'actions'); actions_column.visibility_condition = [% CAN_user_tools_moderate_comments ? 'true' : 'false' | html %]; squashed. Can you please retest? :) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
