https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43370

Jonathan Druart <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

--- Comment #5 from Jonathan Druart <[email protected]> ---
(In reply to David Nind from comment #3)
> I didn't notice any change in behavour before and after the patch, so maybe
> I'm not testing correctly.
> 
> In addition, I'm not sure that I agree with the behavour (both before and
> after the patch).

This is a very complex table, and the column visibility is working differently
than other tables.
This is because there are a lot of columns, and we only want to display those
that contain data.

> I think a column in the holdings table should be shown if:
> 
> 1) It is selected under columns

Almost all columns are selected by default, so we would display all of them.

> AND
> 
> 2) If ANY items have a value, not just the items shown on the current
> results page.

Yes, in an ideal world, but this is not possible. We will need to fetch all
items for that, and that would be a performance killer. This is what we want to
avoid with the server-side processing and the pagination.

For now we are trying to simply make it works like I think it is best. And it's
already not easy :D

Then we will discuss further improvements ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to