https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42605
--- Comment #10 from Jonathan Druart <[email protected]> --- Created attachment 204086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204086&action=edit Bug 42605: Preserve acquisition preference string values Bug 41563 converted AcqCreateItem and UniqueItemFields to booleans when adding them to Koha.prefs. Both preferences are strings: AcqCreateItem controls where items are created, while UniqueItemFields contains a pipe-separated list. When a basket inherits AcqCreateItem=ordering, the boolean value matches none of the receiving page branches and existing items are hidden. When items are created on receiving, the numeric UniqueItemFields value also fails when the page calls split(). Preserve both string values in Koha.prefs. Add a Cypress regression test which renders orderreceive.pl and verifies the values exposed to JavaScript. Test plan: Before applying the patch: 1. Set AcqCreateItem to "placing an order" and UniqueItemFields to "barcode". 2. Create a basket that inherits the system preference. Add an order with one item, close the basket, and start receiving it. 3. Confirm that the Items table has no existing item row and no Receive checkbox. 4. Set AcqCreateItem to "receiving an order" and open the same order for receiving. 5. Confirm that the Items section is empty: no item-entry fields and no Add item button are shown. Apply the patch. After applying the patch: 1. Set AcqCreateItem back to "placing an order" and open the order for receiving again. 2. Confirm that its existing item is listed and has a Receive checkbox. 3. Set AcqCreateItem to "receiving an order" and open the same order again. 4. Confirm that the Items section contains item-entry fields and an Add item button. Co-Authored-By: Loontik <[email protected]> Signed-off-by: David Nind <[email protected]> Signed-off-by: Jonathan Druart <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
