https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43269
Tomás Cohen Arazi (tcohen) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #28 from Tomás Cohen Arazi (tcohen) <[email protected]> --- (In reply to Jonathan Druart from comment #27) > (In reply to Tomás Cohen Arazi (tcohen) from comment #26) > > (In reply to Jonathan Druart from comment #25) > > > Did you see bug 36350? > > > > I hadn't. This is much more specific. > > There is also bug 32476. > > > It just felt too weird adding `use > > C4::Biblio` in the classes I was introducing. > > I don't understand what you mean here. `C4::Biblio::GetAuthorisedValueDesc` takes a framework and tag/subtags as parameters. Refactoring it the way I did is a great improvement on its own. > My point is that there are already 2 attempts at caching in L1 the result of > extensive or widely used/called methods. The description_for solution you > are suggesting here is indeed very (too) specific. We should aim for a more > global and reusable solution. What the 2 other bugs are suggesting. Caching full resultset objects will be complex, full of side effects and edge cases and might probably never get completed. It would be fair to let me move the existing code to a sane place like this bug does, and eventually rewrite it in terms of the new caching solution when that moves. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
