https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31925
--- Comment #15 from David Cook <[email protected]> --- Yeah... I'm slowly starting to tease apart these changes in my mind. I find the Linker and C4::Biblio::LinkBibHeadingsToAuthorities to be quite... interesting... every time I look at them. Ok so LinkBibHeadingsToAuthorities iterates through the bib fields... and using C4::Heading->new_from_field, we get a "heading" object if the MARC Bibliographic Framework is linked to a "Thesaurus" (ie Authority Type), which is problematic in many cases because of the hard-coded codes that bug 41714 tries to solve... The bib field (hard-coded to 6XX) has a 2nd indicator which indicates which thesaurus the subject heading belongs to... Authority records have a position in their 008 which indicates which thesaurus they're from. Got it... -- Ok, the comments and code look more complicated than they are then. A certain number of the changes are actually just refactoring to make the code DRYer... So basically... what we're trying to say here is "AutoCreateAuthorities must include the thesaurus from the bib heading when auto creating a new authority record". Cool. Easy. I reckon we should include more code comments, because it's often not obvious what the code is doing... -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
