https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962
Emily Lamancusa (emlam) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #389 from Emily Lamancusa (emlam) <[email protected]> --- This works really nicely! Thanks for all of your hard work on this, Jake! Note: trivially rebased on top of bug 43313 before testing Testing notes: When I tested on KTD, the updates didn't apply properly until I did a full ktd down / ktd up (I didn't try reset_all, but I was still getting 404s on the display module page after all the other database update, yarn build, restart_all, clear browser cache) Some more minor / edge case bugs and UX things that should get fixed in follow-ups, but aren't regressions or blockers: Bugs: - The sidebar menu in the Displays module is too narrow and wonky-looking - display notes (staff notes and public notes) are not shown in the item holdings table in the staff interface - Action logs for Modify actions should have diffs - "string" bug with the patron checkouts table: if an item is currently on display, the Checked Out From column shows the display home branch instead of the actual checked-out-from branch. The value is correct in the database; the column is just pulling the wrong value. - The last item cannot be removed from the display on the "Edit Display" page; it silently fails to save the change. It can be removed normally using the batch remove. - Currently, it is possible to set the date range on an item such that the item's display period falls wholly or partially outside of the display-level start and end range. When this happens, the item still shows display values even if the current date is outside the active range of the display itself, which is weird behavior. I think it would make the most sense to prevent such a combination of dates from being saved in the first place (but if there's a reason to allow it that I'm not thinking of, then the items should only behave as if they're on display if today's date falls within both the item display date range and the overall display date range). - Shelving location and collection code drop-downs should respect library limitations on authorized values UX things: - If the user has create_displays permission, but not create_displays_from_any_library, it still allows them to select other libraries as the display library, and shows an error when they try to save. Would be better to prevent them from selecting other libraries in the drop-down in the first place. - When deleting a library or item type that is used in a display, it would be good to show a warning that it is used in a display and that the display value will be blanked out if it is deleted. - Text on buttons to batch add/remove items is confusing: "Batch add items from list" "Batch remove items from list" Better would be: "Batch add items to display" "Batch remove items from display" -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
