https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35870
--- Comment #31 from Aleisha Amohia <[email protected]> --- (In reply to Lucas Gass (lukeg) from comment #30) > The updates to api/v1/swagger/paths/authorities.yaml don't seem correct to > me. > > deleteAuthority now only requires 'edit_authorities' ( wrong, i think. ) > addAuthority now only requires 'edit_authorities' ( wrong, i think ) > > updateAuthority requires 'edit_authorities' ( this seems correct ) > > It's all semantics at this point because with one subpermission it is the > same as having the top-level permission, but we should still do it right. Sorry Lucas, maybe I misunderstood what your desired outcome is here. We implemented it this way because of your earlier comment (In reply to Lucas Gass (lukeg) from comment #22) > A couple things: > > 1. You'll need to update t/Koha/Auth/Permissions.t > > 2. In authorities/searchresultlist-auth.tt the edit button doesn't display > without the new permission ( good ). It seems to be the only button in that > column, should we just hide the whole column to users without the > permission? > > 3. Should we update the REST API where applicable: > > api/v1/swagger/paths/authorities.yaml: editauthorities: "1" > api/v1/swagger/paths/authorities.yaml: editauthorities: "1" > api/v1/swagger/paths/authorities.yaml: editauthorities: "1" Can you tell us what change is needed here to get this through? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
