https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30557
Brendan Lawlor <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #91 from Brendan Lawlor <[email protected]> --- Thanks for working on this Olivia! It's going to be a super userful new feature for our libraries! Olivia’s plan: Basic functionality mostly works. There is a permissions issue that prevents adding items from the item search for non super librarians. Some of these points are for more consitent ui and ux improvements. Some are would be nice suggestions and not necessarily blockers. # Creating item lists - Default visibility should be Private, to be consistent with the Lists feature and to save clicks. # On koha/lists/items page - Page is missing <h1> for ‘Item lists’ below the menu buttons above the table to be consistent with other Koha UI and Lists feature - Actions column should use a drop down with Edit, + Add items, Add shares and Delete - Add items and add shares would go direct to forms to add items or shares # On an item list page /koha/lists/items/1 - Page is missing <h1> for ‘Contents of <list name> - The table is missing an option for Home Library, which would be useful, otherwise you’d have to infer that by the barcode prefix. Collection code is another important column for library staff. Enumchron would also be a needed option for periodicals - Filtering is not available for Location and Item Type columns - Allow removing multiple selected items from the list rather than one at a time. There should be a remove selected button like the bib Lists feature has, otherwise managing a long list of items would be frustrating. - Batch edit and Batch delete buttons should be disabled if no items are selected and nothing would be sent to the tool - Not a blocker but note that these buttons look different than other Koha buttons, and links to these functions usually appear under a batch operations dropdown menu in other parts of Koha - It would be nice to show a summary of info about the list above the table including visibility Private/Group/Public and number of shares on this page - Should + Add share button also be visible in the menu bar here if the user has permission to add a share on the /koha/lists/items/1/shares route? I understand if it’s a design chose to keep adding shares totally separated, but it could help managers of the lists to save clicks (not a blocker) # On koha/lists/items/1/add - This page should have the option to add items by itemnumber, consistent with the bibs List feature - Missing an <h1>, Add items is <h2> - Not sure what would be a consistent pattern because the Lists feature uses a modal for adding records instead of a separate page (not a blocker) - Modal: Are you sure you want to remove this item from the list? - Should show more information than barcode, a summary of the row data would help to confirm the item # On koha/lists/items/1/shares - Modal: Are you sure you want to remove this share from the list? - Only displays the borrower number, but should display the patron name and info consistent with other parts of Koha - Adding items from Item search - Permissions issue? According to Andrew’s test plan, a user that does not have any item_lists sub permissions, but has been given ownership or a shared a list with edit permissions by a superlibrarian can not add items via item search. They can add items via the other three methods, Item lists interface, catalog search and reports (if they have access to run reports) - The Batch operations drop down with Batch add to item lists option does not render. - Should this be a separate button from batch operations that update or delete records, considering this only adds records to a list? - For accessibility these should be coded as <button> rather than <a> since they are used for actions not navigation # Adding items from a Report - Menu option name suggestion ‘Add to item list’ to be consistent with but also differentiate ‘Add to list’ #Adding items from item search, holdings table or report - This doesn’t seem to work except for the superlibrarian. Even with the top level item_lists permission the batch operations button doesn’t render without more permissions # Modal: Add items to item list - Allows you to select a list you have permission to add items on - If you have permission to create item lists, the top option should be Create a new list - The Add to list button should have a dropdown for Add to list and view, which would take you to the list you (similar to save and view elsewhere in Koha) - When searching for a patron to set owner or add a share, there is no indication that ‘No matching records were found’. When you submit the form validation says ‘You must select a patron from the results list’ so it would be helpful to indicate that to the user Andrew’s test plan: # 4 - Confirm you can access the Item Lists module and see only the public list and the private list owned by the user - Confirmed, but also note that there is no link from the home page to get here. That actually seems consistent with how Lists works, you need at least one permission to see the menu link, but it seems like a bug because the user can access the module for things that are public/visible to them. The menu link displaying does not seem to have the same control as whether the user can reach the module http://localhost:8081/cgi-bin/koha/virtualshelves/shelves.pl?op=list # 7, 8 and 9 - Click into the list owned by your user, confirm you are able to add items to it - Confirmed # 10 - Confirm your user can add items to the list they own from bib details, item search, and report results - From item search there is No Batch operations drop down with Batch add to item lists option. - Should this be a separate button from batch operations that update or delete records, considering this only adds records to a list? # 11 and 12 - Confirmed #13 - 16 - From item search there is No Batch operations drop down with Batch add to item lists option. # 17 - 18 Confirmed # 19 - 20 Confirmed -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
