https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41151
--- Comment #68 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 204762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204762&action=edit Bug 41151: (follow-up) Restore multi-value list rendering in KohaTable Commit dc280fa ("Display multi-value additional fields as lists in datatables") was reverted in 9e7d7ac because its display logic relied on the same naive comma-split that mangled comma-bearing values, and because the companion export commit (042b0e9) was blocked on a DataTables upgrade. With parseValueStr() in place we can safely restore the display half: reuse the shared parser to turn a multi-value value_str into a <ul>, and return plain value_str for non-display render calls so filtering, sorting, and CSV/Excel export keep working exactly as they do today. HTML-escape each entry on the way in; the original reverted patch interpolated raw field values into markup, which would be a latent XSS for any staff user who could author an additional-field value. The export newline formatting (042b0e9) is deliberately not restored here; it remains blocked on upgrading datatables.net-buttons to 3.2.0+ and datatables.net-vue3 to 3.x for native escapeExcelFormula support. Test plan: 1. Rebuild JS: yarn js:build 2. Load a datatable view that renders a searchable repeatable additional field (e.g. ERM agreements or ILL requests). 3. For a row with three repeats where one value contains commas, confirm the cell shows a bulleted list of three items with the comma-bearing entry intact on its own line. 4. Export the table to CSV; confirm exported cells show the plain comma-separated value_str (unchanged from the current reverted state). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
