https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43127
--- Comment #15 from Matt Blenkinsop <[email protected]> --- Created attachment 204840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204840&action=edit Bug 43127: The Place hold button should be disabled rather than hidden Assisted-by: Sonnet 5 (Anthropic) Test plan: 1) Go to Administration > System preferences, search for UseNewHoldsInterface, set it to "Use", and save. 2) Go to Administration > System preferences, search for AllowHoldPolicyOverride, and set it to "Allow". 3) Search the catalogue, open a record that has at least two items/copies on it, and click "Place hold" - A page opens titled "Place a hold on <record title>", with a box to search for a patron underneath it. 4) Type a patron's name or card number into the search box and click them in the list of suggestions - A chip/tag with the patron's name appears. Underneath it, a form appears with a pickup library dropdown, an expiry date field, a notes field, and a "Place hold" button. A summary line also appears, e.g. "2 item(s), 2 holdable ยท Queue position: #1". 5) Choose a pickup library, pick an expiry date, add a note, and click "Place hold" - A "Queue position: #1" confirmation appears in the bottom right corner of the page, then the page moves to the patron's own record, clicking on holds history shows the new hold at the top of their holds list. 6) Go to Administration > Circulation and fine rules. Find the row for the item type of your test record (or the "All" row) and set "Hold fee" to a non-zero amount, e.g. 3. Save. 7) Open the test patron's own record, click "Search to hold" in the toolbar at the top, then search the catalogue for your test record and click the "Place hold for [patron name]" link/dropdown item next to it in the results - The "Place a hold" page opens with the patron chip already showing that patron - the same as if you'd searched for them by hand, but without needing to. - A blue notice appears above the form: "A fee of 3.00 applies to this hold." Set the hold fee back to blank/0 afterwards. 8) In the same rules row, set "Holds allowed (total)" to 0. Save. Open "Place a hold" again for the same record and patron - The "Place hold" button is visible but greyed out and can't be clicked. A red notice reads "This hold cannot be placed:" followed by "No item on this record can fill a hold" - hovering over the greyed-out button shows the same reason in a tooltip. Set "Holds allowed (total)" back to its original value afterwards. 9) Open the test patron's record, click Edit, and under "Patron account flags" set "Lost card" to Yes. Save. Open "Place a hold" again for that patron and a record without the rule from step 7 - A red notice reads "This hold cannot be placed:" / "The patron's card has been reported lost". Unlike step 7, the "Override and place hold" button is visible below the form, and the expiry date and notes fields are still fillable - pick an expiry date and add a note now, before continuing to the next step. 10) Click "Place hold" - A popup titled "Override required" appears, listing the reason, with "Override" and "Cancel" buttons. 11) Click Cancel - The popup closes and no hold is placed. The "Place hold" button is still there so you can try again. 12) Click "Place hold" again to reopen the popup, then click "Override" inside the popup - Same as step 5 - a "Queue position" confirmation appears and the page moves to the patron's holds, showing the new hold with the expiry date and note you entered in step 8. 13) Go to Administration > System preferences, set AllowHoldPolicyOverride to "Don't allow". Edit the test patron again and set "Lost card" back to Yes if you'd already reverted it. Open "Place a hold" for that patron and record again - The same red notice appears, and the "Place hold" button is greyed out again - the same as step 7. Set AllowHoldPolicyOverride back to "Allow" and the patron's Lost card back to No afterwards. 14) Go to Administration > System preferences and set UseBranchTransferLimits to Enforce and BranchTransferLimitsType to "Item type". Go to Administration > Library transfer limits, and for your test record's home library, block a second library from receiving its item type. Open "Place a hold" for the record/patron, then open the pickup library dropdown without selecting anything yet - The blocked library appears in the list with a warning icon next to its name. Hovering over the icon shows "This pickup location is not allowed according to circulation rules". 15) Select that blocked library from the dropdown - Without reloading the page, the "Place hold" button greys out and a red notice appears, the same way as step 7. The pickup library dropdown stays visible and usable. 16) Change the pickup library dropdown back to the original library - Without reloading the page, the red notice disappears and the "Place hold" button becomes clickable again. Undo the transfer limit and revert UseBranchTransferLimits afterwards. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
