https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43225
--- Comment #7 from David Nind <[email protected]> --- (In reply to Katrin Fischer from comment #5) > I think a string beginning with ". " is quite unusual and is more likely to > be mistranslated. > > Is there a reason we can not put the punctuation and space onto the end of > the previous line? Spaces at the end of lines are more common in > translations and if they are missing, they will be highlighted by the > automated checks in Weblate. > > > var MSG_CONFIRM_RENEW = _("The patron has a debt of > %s").format(fines); > - MSG_CONFIRM_RENEW += _("Are you sure you want to renew > checkout(s)?"); > + MSG_CONFIRM_RENEW += _(". Are you sure you want to renew > checkout(s)?"); I wondered when I did it, but wasn't quite sure. I've updated the change so that it does it this way: - var MSG_CONFIRM_RENEW = _("The patron has a debt of %s").format(fines); + var MSG_CONFIRM_RENEW = _("The patron has a debt of %s.").format(fines) + " "; MSG_CONFIRM_RENEW += _("Are you sure you want to renew checkout(s)?"); Is this a better way? Will the empty space added with the + " " cause any issues with translation? David -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
