https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30144
--- Comment #74 from Martin Renvoize (ashimema) <[email protected]> --- Created attachment 205178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205178&action=edit Bug 30144: (QA follow-up) Fix t/Ediorder.t for JSON servicing_instruction format Bug 30144 changed Koha::Edifact::Order::gir_segments() to expect servicing_instruction as a JSON-encoded array of instruction groups (added by Bug 41709 while working with the older plain-string format that predated Bug 30144's change was never adapted to match). As a plain string no longer decodes as JSON, gir_segments() silently skipped the servicing instruction elements, leaving the GIR split and special-character tests comparing against undef. Test plan: 1. prove t/Ediorder.t => 4 tests failed before this patch, all pass after 2. prove t/db_dependent/Koha/Edifact/Order.t => still passes Signed-off-by: Martin Renvoize <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
