https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21453
Konstantinos Daskalopoulos <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #22 from Konstantinos Daskalopoulos <[email protected]> --- Created attachment 205379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205379&action=edit Bug 21453: (follow-up) fix authority linking from cataloguing editor in UNIMARC We independently hit this regression on production UNIMARC installations (Zebra), confirming comment 21: after using "Create new authority" from the bibliographic editor's authority finder (e.g. on field 600), the popup hangs on its spinner and the console shows "authid_subfield is not defined". The heading text is copied but $9 is left empty, so the field stays unmatched and both windows stay open. MARC21 is unaffected because it declared the variable unconditionally. Root cause: the "Create new authority" button in auth-finder-search.js does not pass 'source', and authorities.pl does not forward it in the redirect to blinddetail-biblio-search.pl after saving. Under UNIMARC neither the source == 'auth' nor the source == 'biblio' branch matched, so authid_subfield was never declared and the next line threw. This follow-up patch (a) propagates 'source' through the "Create new authority" flow (auth_finder.tt exposes it to JS, auth-finder-search.js sends it, authorities.pl forwards it in the redirect) so the created authority is linked into the correct subfield, and (b) makes blinddetail-biblio-search.tt declare authid_subfield unconditionally -- "3" only for authority-to-authority linking in UNIMARC (source == 'auth'), "9" otherwise -- which is also defensive against any caller that omits 'source'. Reproduced and verified on current main with KTD (UNIMARC); the QA test tools pass on all changed files. Test plan is in the patch. Happy to move this to a separate follow-up bug if you'd prefer to keep the revert discussion here -- just let me know. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
