https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31457
--- Comment #8 from Baptiste Wojtkowski (bwoj) <[email protected]> --- Created attachment 205386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205386&action=edit Bug 31457: Remove the deprecated Koha::Patron::Debarments shim Now that all callers use the object-oriented restriction API, this patch removes the Koha::Patron::Debarments compatibility shim and migrates the last remaining (incidental) callers, which were test setups. Changes: - Remove Koha/Patron/Debarments.pm - Remove t/db_dependent/Patron/Borrower_Debarments.t (its coverage now lives in Restriction.t, Restrictions.t, Restriction/Types.t and Koha/Patron.t) - Migrate incidental test callers to the OO API: Circulation.t, Circulation/MarkIssueReturned.t, Circulation/maxsuspensiondays.t, Members.t, Koha/Patron.t, api/v1/patrons.t, api/v1/holds.t - misc/cronjobs/cleanup_database.pl: require Koha::Patron::Restrictions (the class actually used) instead of the removed module - Koha::Patron::Restriction::Type: refresh an outdated comment (the raw SQL bulk type reassignment is kept on purpose to avoid per-row store triggers) Test plan: 1. Apply patch 2. Confirm nothing loads the removed module: $ git grep "Koha::Patron::Debarments" -- ":!misc/release_notes" => SUCCESS: no matches 3. Run: $ ktd --shell k$ prove t/db_dependent/Koha/Patron/Restriction.t \ t/db_dependent/Koha/Patron/Restrictions.t \ t/db_dependent/Koha/Patron/Restriction/Type.t \ t/db_dependent/Koha/Patron/Restriction/Types.t \ t/db_dependent/Koha/Patron.t \ t/db_dependent/Circulation.t \ t/db_dependent/Circulation/MarkIssueReturned.t \ t/db_dependent/Circulation/maxsuspensiondays.t \ t/db_dependent/Members.t \ t/db_dependent/api/v1/patrons.t \ t/db_dependent/api/v1/holds.t => SUCCESS: All tests pass! 4. Sign off :-D Signed-off-by: Baptiste Wojtkowski <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
