https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41920

Pedro Amorim (ammopt) <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #18 from Pedro Amorim (ammopt) <[email protected]> ---
Hey, a few things here:

1) The 2nd patch appears to have been wrongly rebased (It's duplicating code).
Please double-check.
2) Test coverage for total_running_reports_per_instance_limit would be ideal,
not only because it's a new config but also because its siblings
total_running_reports_per_user_limit and
duplicate_running_reports_per_user_limit already have it.
3) $instance_id variable declared but never used in guided_reports.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to