https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42835

--- Comment #60 from Martin Renvoize (ashimema) 
<[email protected]> ---
Created attachment 205425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205425&action=edit
Bug 42835: (QA follow-up) Only treat a genuine holdingbranch value change as a
transfer

The previous fix for skipping the biblio re-index on branch transfers used
exists $updated_columns{onloan} / {issues} as a proxy for "this is a
checkout, not a transfer". That misses the case where a checkout also
moves the item to a different branch than it currently has: onloan being
dirty made is_branch_transfer false, so the branch-facet-relevant change
was silently skipped along with the safe circ-only fields.

Compare the actual holdingbranch value against the pre-store item instead
of looking at which other columns happen to be dirty. A holdingbranch
value that hasn't actually changed (AddIssue re-asserting the current
branch alongside onloan) is still skippable; any real branch change now
always forces a re-index, regardless of what else changed in the same
store() call.

Test plan:
1) Run: prove t/db_dependent/Koha/Item.t

Co-Authored-By: Claude Sonnet 5 <[email protected]>

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to