https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43505

--- Comment #13 from Jonathan Druart <[email protected]> ---
Created attachment 205465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205465&action=edit
Bug 43505: Koha::QA - Tidy::JS

Replace the direct `yarn --silent run prettier` command with 
Koha::QA::Tidy::JS.

Test plan:
0. You will need the merge request from
https://gitlab.com/koha-community/koha-testing-docker/-/work_items/562
Or build Koha::QA with `make js-deps` (see its README)
1. `perl misc/devel/tidy.pl /path/to/file.js` on a .js file and confirm
   it tidy the same way as before.

QA: We previously ran whatever prettier available via Koha's own
root-level.  It now runs the prettier provided by Koha::QA (see its
File::ShareDir share directory) Which is only populated by Koha::QA's
`make js-deps` build step.
See the koha-testing-docker and qa-test-tools patches doing that.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list -- [email protected]
To unsubscribe send an email to [email protected]
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to