https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41719
--- Comment #7 from Chris Nighswonger <[email protected]> --- Created attachment 205665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205665&action=edit Bug 41719: Add rendering test coverage for Labels and Patroncards Pre-signoff revision. Two changes from the previous attachment (202134): **1. CODE39MOD/CODE39MOD10 rows wrapped in TODO { }.** Those two rows die on `Undefined subroutine Algorithm::CheckDigits` until Bug 43095 lands (surfaced by the coverage work in the first place). Previously the file was intentionally red on those two lines and disclosed as such; a reviewer running `prove` first sees red and can Failed-QA before reaching the disclosure. Wrapping in TODO with the blocking bug named in `$TODO` returns the file to a green overall PASS while still exercising the code path. When Bug 43095 lands, the rows unexpectedly-succeed and the TODO wrapper is removed. **2. `chmod +x` on the new `t/db_dependent/Patroncards/t_Patroncard.t`.** The prior attachment was `100644`; `koha-qa.pl` flags this as `file_permissions: File must have the exec flag`. Now `100755`, matching its sibling `t/db_dependent/Labels/t_Label.t` and every other Koha test file. Test plan step 3 updated to describe the TODO output shape. Step 4 updated to note that removing the TODO wrapper is the follow-up when Bug 43095 lands (else Test::More reports "TODO unexpectedly succeeded"). `koha-qa.pl -c 1` PASS on both files. `prove t/db_dependent/Labels/t_Label.t t/db_dependent/Patroncards/t_Patroncard.t` PASS. AI review disclosure per Coding_Guidelines §1.8 §4: this rework was authored by Claude Opus 4.7 (Anthropic) under human direction and reviewed by OpenAI Codex GPT-5.5 (OpenAI) as an independent cross-vendor second reviewer. Codex ran isolated `Test::More` probes to verify the TODO semantics on three edge cases (TODO-wrapped fail, TODO-wrapped unexpected-pass, unwrapped `die` still aborting) and confirmed correctness against the diff; no blocker or should-fix findings. Previous review chain intact in commit trailers: Claude Opus 4.5 authored the tests; Claude Fable 5 and OpenAI Codex GPT-5.5 reviewed prior revisions. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
