https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31391
--- Comment #284 from Katrin Fischer <[email protected]> --- Created attachment 205760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205760&action=edit Bug 31391: (QA follow-up) Hide "Convert selected to recall" for users with no recalls permission This introduces a permission check on "recalls" for the link on the holds summary page. 1) Go to http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl, and under the default rule, set: - 'Recalls allowed (total)': 5 - 'Recalls per record': 3 - 'On shelf recalls allowed': if any unavailable - 'Recall due date interval': 5 - 'Recall overdue fine amount': 5 - 'Recall pickup period': 2 2) Go to 'Administration' > 'Global system preferences' (http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=UseRecalls), set 'UseRecalls' to 'can be placed through the staff interface only'. 3) Go to Henry's patron account, borrowernumber 19, set him a password (http://localhost:8081/cgi-bin/koha/members/member-password.pl?member=19), then edit his permissions (http://localhost:8081/cgi-bin/koha/members/member-flags.pl?member=19) and give him only 'catalogue' and 'reserveforothers' (place holds), do not give him 'recalls'. 4) As a superlibrarian, check out item 39999000003154 (biblionumber 76) to borrowernumber 23, then place a hold on that same record for borrowernumber 49 5) Log out and log back in as Henry. 6) Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=76, tick the checkbox next to the hold, click 'Convert selected to recall', confirm in the modal. 7) The hold gets cancelled and a recall gets created, even though Henry has no recalls permission at all, proving the action isn't actually gated by it. 8) Apply patch, re-run test plan to 6) - The link to convert should no longer display. 9) Toggle the recalls permission for Henry, link to convert should now reappear. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
