https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17921
--- Comment #10 from Tomás Cohen Arazi (tcohen) <[email protected]> --- Created attachment 205893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205893&action=edit Bug 17921: Use cached name_for/description_for in the shelf browser This patch makes the shelf browser reuse the cached class methods added by bug 43269 for resolving the starting shelf descriptions, instead of a direct Koha::Libraries->find and the legacy C4::Biblio::GetAuthorisedValueDesc. Changes: - Homebranch: Koha::Libraries->find(...)->branchname => Koha::Libraries->name_for - Location (LOC) and collection code (CCODE): GetAuthorisedValueDesc(...) => Koha::AuthorisedValues->description_for - Drop the now unused 'use C4::Biblio qw( GetAuthorisedValueDesc )' - No functional changes, the resolved descriptions are the same Test plan: 1. Have OPACShelfBrowser, ShelfBrowserUsesHomeBranch, ShelfBrowserUsesLocation and ShelfBrowserUsesCcode enabled 2. Open the OPAC detail page for an item and open the shelf browser 3. Notice the starting homebranch, location and ccode descriptions are shown correctly, as before 4. Run: $ ktd --shell k$ prove t/db_dependent/ShelfBrowser.t => SUCCESS: Tests pass! 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
