https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42500
--- Comment #19 from Andrew Fuerste-Henry <[email protected]> --- In order to test these patches, I've worked to confirm the current functionality, which led me to file Bug 43541, highlighting inconsistencies in how this report counts unreceived orders without attached items. With these patches, the hold ratios report *never* includes unreceived orders without attached items (rather than counting them sometimes, as the current code does), introducing a new and different issue. I don't think it makes sense to replicate the current faulty behavior in these patches, or to patch Bug 43541 on the current code before updating these patches to match the updated behavior. I suggest we simply update these patches to match the ideal behavior I've suggested on Bug 43541: - Allow un-received orders without attached items to be included in the hold ratio items count when one is accessing the hold ratios via circulation - Allow un-received orders without attached items to be included in the hold ratio items count when one is accessing the hold ratios via acquistions regardless of the create_items value of the basket to which one is adding orders - In either circulation or acquisitions, only include un-received orders without attached items if the "Include ordered" checkbox has been selected - Never count un-received orders with attached items (count the item instead) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
