https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41023
--- Comment #5 from Mathieu Saby <[email protected]> --- Thank you for this patch. Overall, it works, but I'm hesitant to sign off for the reasons explained at the bottom of the comment. Maybe your test plan should be more detailed, I'm not sure I've thoroughly tested all the relevant pages. I'm testing in a Biblibre sandbox (marc21, elasticsearch) 1. On the holdings table under a record : The record has 2 items in 2 libraries (Fairview, Midway). I enable the column filters. In the homebranch filter I select Midway; the table refreshes, and only one item is now visible. I click again in the menu to also select Fairview. There are now two libraries selected in the filter. The table refreshes, and both items appear. I add more libraries to the filter, and the table refreshes, the 2 items are still visible. I run other similar tests; everything seems to be working. The x before the name of a library is working : it removes the library of the filter, without removing the others. The x on the top of all the names is working : it removes all the libraries of the filters I did the same for current library and item type. It works. Status column is not affected, it works like before, as it shoud do. 2. I did a patron search in members/members-home.pl I applied filters on Libray and Category columns. It works well, like on the holding table. However I raise these concerns : - you can’t select four value at once because the filter activates as soon as you select the first one. So you have to apply other values one at a time. Maybe some people won’t like that, but I’m not sure that another approach (like adding a button to confirm the filter?) would be a good idea. The patch as proposed is already a major step forward. But maybe you should describe this behavior more clearly in the test plan and bug description ? - there’s a minor display issue: the library names aren’t properly aligned in the selection filter. Maybe they’re centered ? In any case, it looks strange. Is it possible to fix this so that they appear exactly one below the other and left-aligned? - When I filter on holding columns I see this warning in my console. I do not know if it is related : Blocked aria-hidden on an element because its descendant retained focus. The focus must not be hidden from assistive technology users. Avoid using aria-hidden on a focused element or its ancestor. Consider using the inert attribute instead, which will also prevent focus. For more details, see the aria-hidden section of the WAI-ARIA specification at https://w3c.github.io/aria/#aria-hidden. Element with focus: <textarea.select2-search__field> Ancestor with aria-hidden: <table.items_table dataTable fixedHeader-floating> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
