https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542
Baptiste Wojtkowski (bwoj) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Baptiste Wojtkowski (bwoj) <[email protected]> --- > 144 if (!loaded && counter_wait < 50) {// Do not wait more than 5 > > seconds > 145 window.setTimeout(function(){wait_for_images(cb);}, 100); > 146 } else { > 147 if (counter_wait >= 50 ) { > 148 console.log("Could not retrieve the images") > 149 } All three numbers depend from each others, for sake of maintainability please use one constant there. QA tools are not happy : Processing files [RUNNING] koha-tmpl/intranet-tmpl/js/coce.js [RUNNING] koha-tmpl/intranet-tmpl/prog/js/pages/results.js [PASS] koha-tmpl/intranet-tmpl/js/coce.js [FAIL] koha-tmpl/intranet-tmpl/prog/js/pages/results.js Result: [PASS] koha-tmpl/intranet-tmpl/js/coce.js [FAIL] koha-tmpl/intranet-tmpl/prog/js/pages/results.js FAIL forbidden_patterns forbidden pattern: console.log (line 148) FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/js/pages/results.js` -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list -- [email protected] To unsubscribe send an email to [email protected] website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
